Pymavlink mavftp

[amilcarlucas]

Description

Describe what this PR is trying to achieve. Please read our Contributing Guide for detailed guidelines.

Checklist

• Run pre-commit checks locally
• Verified by a human programmer
• All commits are signed off (use git commit --signoff)
• Code follows our coding standards
• Documentation updated if needed
• No breaking changes or properly documented

Testing

Describe how you tested these changes:

• Unit tests pass
• Integration tests pass
• Manual testing performed
• Tested on flight controller hardware

[Copilot]

Pull request overview

This PR tightens up the MAVLink FTP backend implementation by adding type annotations, improving None-safety around FTP payload handling, and removing the Ruff per-file ignore for backend_mavftp.py so the file is linted consistently with the rest of the project.

Changes:

• Added/expanded type annotations across MAVFTP-related classes and methods (callbacks, args, internal helpers).
• Hardened several code paths against None payloads and ensured numeric settings are coerced to int where required.
• Removed the Ruff per-file ignore for ardupilot_methodic_configurator/backend_mavftp.py and added targeted # noqa annotations in-code instead.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
pyproject.toml	Removes Ruff per-file ignores for backend_mavftp.py, making it subject to standard linting rules.
ardupilot_methodic_configurator/backend_mavftp.py	Adds typing and None-safety improvements throughout the MAVFTP implementation and CLI helpers.

Comments suppressed due to low confidence (1)

ardupilot_methodic_configurator/backend_mavftp.py:1682

• The heartbeat log message prints the system ID twice; the second placeholder is labeled "component" but uses m.target_system again. This makes the log misleading and can complicate debugging multi-component systems.

def wait_heartbeat(m: "MavlinkConnection") -> None:
    """Wait for a heartbeat so we know the target system IDs."""
    logging.info("Waiting for flight controller heartbeat")
    m.wait_heartbeat(timeout=5)
    logging.info("Heartbeat from system %u, component %u", m.target_system, m.target_system)

[github-actions]

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements	Covered	Coverage	Threshold	Status
13151	12410	94%	89%	🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: be0f919 by action🐍

[github-actions]

Test Results

     4 files  ±0       4 suites  ±0   44m 4s ⏱️ +8s
 4 047 tests ±0   4 039 ✅  - 1   7 💤 ±0  0 ❌ ±0  1 🔥 +1 
15 980 runs  ±0  15 934 ✅ ±0  45 💤  - 1  0 ❌ ±0  1 🔥 +1 

For more details on these errors, see this check.

Results for commit be0f919. ± Comparison against base commit c893c4a.

♻️ This comment has been updated with latest results.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

ardupilot_methodic_configurator/backend_mavftp.py:1682

• The heartbeat log message prints m.target_system for both the system and component fields, so the component ID is never shown correctly.

def wait_heartbeat(m: "MavlinkConnection") -> None:
    """Wait for a heartbeat so we know the target system IDs."""
    logging.info("Waiting for flight controller heartbeat")
    m.wait_heartbeat(timeout=5)
    logging.info("Heartbeat from system %u, component %u", m.target_system, m.target_system)