Skip to content

move description of project above the community content on ardupilot.org #6752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nkruzan
Copy link
Member

@nkruzan nkruzan commented Apr 8, 2025

Seems to me to be more appropriate placement of description of project.

@Hwurzburg Hwurzburg requested a review from rmackay9 April 8, 2025 21:18
@Hwurzburg
Copy link
Contributor

@rmackay9 doesnt bother me, if you are okay with it I will merge

@rmackay9
Copy link
Contributor

rmackay9 commented Apr 8, 2025

Hi @Hwurzburg, TBH, I'm not sure where these paragraphs are on the wiki... it's probably obvious but I can't immediately find it

@nkruzan
Copy link
Member Author

nkruzan commented Apr 9, 2025

https://ardupilot.org @rmackay9 is the main website

@rmackay9
Copy link
Contributor

rmackay9 commented Apr 9, 2025

If I understand correctly I think this would move the blog posts lower on ardupilot.org which I don't think we should do. I think we need to keep the blogs at the very top

We could move the "Community" title and the single line under it to be below the Blogs section.

@rmackay9
Copy link
Contributor

rmackay9 commented Apr 9, 2025

Thanks very much @nkruzan for trying to make our wiki better though!

@nkruzan
Copy link
Member Author

nkruzan commented Apr 9, 2025

This content should have never been moved 3/4 of the way down the page.

Nearly every open source software home page starts with an introduction of what the software is.

Examples:

https://www.gnu.org/

Pick any random package here:
https://www.gnu.org/software/software.html#allgnupkgs

https://rsync.samba.org/

https://www.samba.org/

https://linuxmint.com/

https://www.gimp.org/

@nkruzan
Copy link
Member Author

nkruzan commented Apr 9, 2025

Thanks very much @nkruzan for trying to make our wiki better though!

I am #8 on the list...I do make our wiki better.

edit:removed giant pic that wasn't that big on mobile.

@rmackay9
Copy link
Contributor

rmackay9 commented Apr 9, 2025

@nkruzan,

I'm happy for the little blurb on what AP is to move to above the blog posts but shoving all the blog posts down too low will make them essentially invisible.

I think the difference between AP and the projects mentioned is that AP has an active user community and the blogs help us keep engaged with them

@nkruzan
Copy link
Member Author

nkruzan commented Apr 9, 2025

I'm happy for the little blurb on what AP is to move to above the blog posts but shoving all the blog posts down too low will make them essentially invisible.

I have move the other text back down

@nkruzan nkruzan force-pushed the pr/reorganize-ardupilot-org-homepage branch 2 times, most recently from 4fcd946 to a1ec165 Compare April 9, 2025 01:25
@nkruzan
Copy link
Member Author

nkruzan commented Apr 9, 2025

Pretty sure I have fixed my changes now

@Hwurzburg
Copy link
Contributor

@khancyr we cant get this to pass CI....HTML sipalys okay in browser

@nkruzan nkruzan force-pushed the pr/reorganize-ardupilot-org-homepage branch from a1ec165 to 1a39dec Compare April 15, 2025 02:32
@nkruzan
Copy link
Member Author

nkruzan commented Apr 15, 2025

force pushed and it passes now

Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets make thee gap between What is ArduPilot and the gallery one line, same for gap after and before Community...this should address @rmackay9 concerns and he can approve

@nkruzan
Copy link
Member Author

nkruzan commented Apr 15, 2025

lets make thee gap between What is ArduPilot and the gallery one line, same for gap after and before Community...this should address @rmackay9 concerns and he can approve

i think i have done this as you requested

@nkruzan
Copy link
Member Author

nkruzan commented Apr 15, 2025

@Hwurzburg does this need squashed to 1 commit

Copy link
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, squash to one commit please..

@nkruzan nkruzan force-pushed the pr/reorganize-ardupilot-org-homepage branch 2 times, most recently from 9d990cf to 022c27f Compare April 15, 2025 13:51
fix typo

remove excess line breaks 

remove some blank lines
@nkruzan nkruzan force-pushed the pr/reorganize-ardupilot-org-homepage branch from 022c27f to 221fd91 Compare April 15, 2025 14:04
Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice to see this finally done !

@Hwurzburg
Copy link
Contributor

Hwurzburg commented Apr 17, 2025

@rmackay9 this acccomplishes what you asked..so merging without your formal approval

@Hwurzburg Hwurzburg merged commit 1616b02 into ArduPilot:master Apr 17, 2025
5 checks passed
@rmackay9
Copy link
Contributor

yeah, it looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants