Skip to content

Some overdue updates for Vicon Positioning System's doc#7824

Open
MatthewT0809 wants to merge 1 commit into
ArduPilot:masterfrom
MatthewT0809:master
Open

Some overdue updates for Vicon Positioning System's doc#7824
MatthewT0809 wants to merge 1 commit into
ArduPilot:masterfrom
MatthewT0809:master

Conversation

@MatthewT0809

Copy link
Copy Markdown

Feel free to change the wording and everything as you see fit.

I am reachable via email @ Matthewchtam@gmail.com.

@Hwurzburg
Hwurzburg requested a review from rmackay9 June 30, 2026 01:04
@@ -1,253 +1,365 @@
.. _common-vicon-for-nongps-navigation:
.. _Vicon Positioning System as fake GPS for Indoor Flight:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this. we shouldn't change the first line though, we always make the link the same as the filename prefixed with an underscore

Using a Vicon indoor positioning system
=======================================
===========================================================
Vicon Positioning System as fake GPS for Indoor Flight

@rmackay9 rmackay9 Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I'm not a fan of "fake GPS" in the title so let's just leave it as it was

@MatthewT0809 MatthewT0809 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes with the 1st line and the name of the page, as requested.

@MatthewT0809

Copy link
Copy Markdown
Author

Checking in with this. Any updates on this request?
Please let me know.

@Hwurzburg

Copy link
Copy Markdown
Contributor

has merge conflicts and Randy must approve

@Hwurzburg Hwurzburg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must fix issues with copywiki and fix merge conflicts

Comment thread common/source/docs/common-vicon-for-nongps-navigation.rst Outdated
@Hwurzburg

Copy link
Copy Markdown
Contributor

last merge should be a CI failure...merges of master are not permitted...if you MUST (only needed if a master change makes CI fail on the PR)...rebase it

@MatthewT0809

MatthewT0809 commented Jul 16, 2026

Copy link
Copy Markdown
Author

See if that worked, rebased, added blimp, not too sure what you meant with rover's TOC but I updated the doc in /common and I didn't change the naming convention as Rmackay9 suggested, so rover should be able to refer to it.

Few fixes with referencing in my guide that I missed which failed the build. I tried the build again locally and no warning from my end.

@Hwurzburg
Hwurzburg requested a review from rmackay9 July 16, 2026 20:58
@rmackay9

Copy link
Copy Markdown
Contributor

BTW, I think it was @tridge who wrote this page. I've never actually used a Vicon system.

@Hwurzburg
Hwurzburg requested review from tridge and removed request for rmackay9 July 18, 2026 01:04
@Hwurzburg

Copy link
Copy Markdown
Contributor

okay, will gate this on @tridge approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants