Fix bug in asset's semver comparison

[flatrow]

As stated in api.md asset version id is formatted as name_flavor, resulting in TypeError: Invalid version: 0.0.2_default when more than one latestVersion asset is available.

[DustinBrett]

So this is for comparison within the same flavor? Not comparing different flavors? If so, then that seems like a valid bug.

[flatrow]

As I see versions are filtered by flavor at line 352 of VersionController:

          .find(UtilityService.getTruthyObject({
            channel: applicableChannels,
            createdAt: createdAtFilter,
            availability: availabilityFilter(),
            flavor
          }))

Though I can double check with different flavors because I have used only default, but anyway semver cannot compare anything but versions and that's what fix is about.

[DustinBrett]

Ya I agree the semver fix makes sense. I just had a concern about mixing up flavors as they are not meant to be compared.

[flatrow]

Yeah, I understand your concern and will test this scenario in a few days.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ArekSredzki]

@flatrow Did you ever get a chance to test that edge case?