Skip to content

fix: reject read offset=0 and suppress bogus note for limit=0 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ariasu123 merged 1 commit into from
Aug 15, 2026
Merged

fix: reject read offset=0 and suppress bogus note for limit=0 #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions pion/tools/read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,21 @@ async def execute(
)

lines = text.split("\n")
total_lines = len(lines)

total_lines = len(lines)
# offset is 1-indexed; 0 is invalid and would otherwise silently
# select the last line via lines[-1:].
if args.offset == 0:
return AgentToolResult.text(
"Error: offset is 1-indexed; use offset=1 for the first line "
"(negative values read from the end of the file)",
details=self._details(
{
"truncated": False,
"linesReturned": 0,
"totalLines": total_lines,
}
),
)
# Convert 1-indexed offset to a 0-indexed start. Negative offset: from the end.
if args.offset < 0:
start = max(0, total_lines + args.offset)
Expand Down Expand Up @@ -154,7 +167,7 @@ async def execute(
output = "\n".join(out_lines)
first_display = start + 1
last_display = start + len(out_lines)
if last_display < total_lines:
if out_lines and last_display < total_lines:
note = f"[Showing lines {first_display}-{last_display} of {total_lines}. Use offset={last_display + 1} to continue.]"
output = f"{output}\n\n{note}" if output else note

Expand Down
Loading