fix: Dspy Uninstrumenting instrumented methods #2511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyadevai
force-pushed
the
1063-dspy-uninstrumentation
branch
from
721a8ab to
18cf0f2
Compare
dosubot
bot
added
the
size:L
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...tation/openinference-instrumentation-dspy/src/openinference/instrumentation/dspy/__init__.py
Outdated
Show resolved
Hide resolved
caroger
reviewed
Dec 12, 2025
| lm = LM("openai/gpt-4.1") | ||
| output = lm("hello!") | ||
| print(f"{output=}") | ||
| DSPyInstrumentor().uninstrument() |
Collaborator
There was a problem hiding this comment.
Do we expect users to explicitly call the uninstrument() method?
Collaborator
Author
There was a problem hiding this comment.
No, this isn’t expected in normal usage. The uninstrument() call is used here purely for testing, to validate that uninstrumentation works correctly or not.
caroger
reviewed
Dec 12, 2025
python/instrumentation/openinference-instrumentation-dspy/pyproject.toml
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-dspy/src/openinference/instrumentation/dspy/__init__.py
Show resolved
Hide resolved
caroger
requested changes
Dec 16, 2025
Collaborator
caroger
left a comment
caroger
left a comment
There was a problem hiding this comment.
please respond to/address all review comments (including cursor bots) before marking them resolved.
…adevai/openinference into 1063-dspy-uninstrumentation
...tation/openinference-instrumentation-dspy/src/openinference/instrumentation/dspy/__init__.py
Show resolved
Hide resolved
satyadevai
force-pushed
the
1063-dspy-uninstrumentation
branch
from
8d2c567 to
c99fb9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1063
Note
Track and restore all wrapt-patched DSPy methods to properly uninstrument; add tests and update example to demonstrate uninstrumentation.
_wrap_objectto track all wrapped targets and store originals.unwrap_objectusingresolve_path/apply_patchto restore originals._instrumentto use_wrap_objectacross all DSPy targets; update_uninstrumentto reverse-unpatch all tracked methods.test_uninstrumentto verify all instrumented methods are unwrapped.examples/lm.pyto usegpt-4.1, guard with__main__, and demonstrateuninstrument()behavior.Written by Cursor Bugbot for commit c99fb9b. This will update automatically on new commits. Configure here.