-
Notifications
You must be signed in to change notification settings - Fork 172
fix(langchain): Handle Non-String Dictionary Keys #2555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ialisaleh
wants to merge
7
commits into
Arize-ai:main
Choose a base branch
from
ialisaleh:alisaleh/ticket-2507
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...eninference-instrumentation-langchain/src/openinference/instrumentation/langchain/_tracer.py
Show resolved
Hide resolved
...eninference-instrumentation-langchain/src/openinference/instrumentation/langchain/_tracer.py
Show resolved
Hide resolved
...eninference-instrumentation-langchain/src/openinference/instrumentation/langchain/_tracer.py
Show resolved
Hide resolved
...on/instrumentation/openinference-instrumentation-langchain/tests/test_stringify_dict_keys.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2507
Note
Stringifies non-string dict keys and normalizes containers before JSON serialization, updating
_json_dumps/safe_json_dumpsand adding focused tests._stringify_dict_keysto recursively convert dict keys to strings and normalize containers (sets→lists, tuples/lists preserved).safe_json_dumpswith a newsafe_json_dumpsthat normalizes objects first._json_dumpsto normalize input, use custom encoder, and catchRecursionErrorfallback tosafe_json_dumps.safe_json_dumpsas_original_safe_json_dumps.test_stringify_dict_keys.pywith cases covering Enums, sets/frozensets, tuples, nested structures, and primitives.Written by Cursor Bugbot for commit e06ff15. This will update automatically on new commits. Configure here.