Feat: add Open Agent Spec Instrumentor #2560
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
mikeldking
reviewed
Dec 23, 2025
Comment on lines
+1
to
+7
| # Changelog | ||
|
|
||
| ## 0.1.0 (2025-12-24) | ||
|
|
||
| ### Features | ||
|
|
||
| * Agent Spec instrumentation ([#ISSUE_LINK](https://github.com/Arize-ai/openinference/issues/)) ([COMMIT_ID](https://github.com/Arize-ai/openinference/commit/)) |
Collaborator
There was a problem hiding this comment.
FYI this will be auto-generated by release please as long as the conventional commit message is setup.
Comment on lines
+62
to
+72
| from opentelemetry.exporter.otlp.proto.http.trace_exporter import OTLPSpanExporter | ||
| from opentelemetry.sdk.trace import TracerProvider | ||
| from opentelemetry.sdk.trace.export import SimpleSpanProcessor | ||
|
|
||
| from openinference.instrumentation.agentspec import AgentSpecInstrumentor | ||
|
|
||
| endpoint = "http://127.0.0.1:6006/v1/traces" | ||
| tracer_provider = TracerProvider() | ||
| tracer_provider.add_span_processor(SimpleSpanProcessor(OTLPSpanExporter(endpoint))) | ||
|
|
||
| AgentSpecInstrumentor().instrument(tracer_provider=tracer_provider) |
Collaborator
There was a problem hiding this comment.
non-blocking but this is a bit simpler with phoenix-otel if desired. https://pypi.org/project/arize-phoenix-otel/
But for this block probably best to do it this way. https://pypi.org/project/arize-phoenix-otel/
| def _to_open_inference_format_tracing_info( | ||
| span: AgentSpecSpan, mask_sensitive_information: bool = True | ||
| ) -> Dict[str, Any]: | ||
| # See https://arize.com/docs/ax/concepts/tracing/semantic-conventions for naming conventions |
Collaborator
There was a problem hiding this comment.
Suggested change
| # See https://arize.com/docs/ax/concepts/tracing/semantic-conventions for naming conventions | |
| # See https://arize-ai.github.io/openinference/spec/ for naming conventions |
more up to date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2559
Implementation of a new Instrumentor class that supports Open Agent Specification Tracing.
The PR includes the implementation of the new Instrumentor class for Agent Spec, and all the requirements for the introduction and the release of a new Instrumentor as part of OpenInference.
Since
pyagentspec==26.1.0has not been released publicly on the Pypi index yet, it requires to be manually installed from source from https://github.com/oracle/agent-spec. As soon as it will be publicly available, we will perform a new typing check on the code, and theskip_dep_check=Trueflag setup, currently needed to correctly run examples and tests, will be removed.