-
Notifications
You must be signed in to change notification settings - Fork 488
feat: Declarative eval #7315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Declarative eval #7315
Conversation
* docs(client): add general rules for the client * cleanup * Update packages/phoenix-client/.cursor/rules/general.mdc Co-authored-by: Roger Yang <[email protected]> * Update packages/phoenix-client/.cursor/rules/general.mdc Co-authored-by: Roger Yang <[email protected]> * Update packages/phoenix-client/.cursor/rules/general.mdc Co-authored-by: Roger Yang <[email protected]> --------- Co-authored-by: Roger Yang <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I see im getting errors with importing the new functions, not sure How concerned I should be:
As discussed with @cephalization in https://arize-ai.slack.com/archives/C018252LE1E/p1745724863399289?thread_ts=1745694183.495699&cid=C018252LE1E the import was working as long as |
index=dataframe_index, | ||
) | ||
|
||
return results_data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This return results_data
statement on line 408 is unreachable code since the function already returns a DataFrame on line 406. This redundant return statement should be removed to avoid confusion.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Description
Adds
declarative_eval
andtransform_field_mappings_for_explanation
toarize-phoenix-evals
Offline evaluator function designed after
llm_classify
for declarative evaluations enabling the user to describe evaluations through a PydanticBaseModel
subclass.This enables free-form extensive evaluations according to the user's needs. Useful when
llm_classify
or other specialized evaluator functions are insufficient or the user may need multiple evaluations but wants to minimize overhead.Note: This PR is 45% me learning the repo and dev flow, 45% I find it useful, 10% speculate others may find it useful.
Expample use
(copied from docstring)
Test coverage
provide_explanation
field_mappings
TODO
OpenAIModel
)Client(...).log_evaluations_sync(...)
)