fix: change INT to BIGINT for primary keys in PostgreSQL #7327
+25,644
−4,219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Drop unique constraint migration * Update /span_annotations REST route * Update bulk inserters * Update data loader to aggregate label fractions per span first * Use correct kwarg name * Use sqlite compatible migration * Always use batch_alter_table * Ensure that spans with an annotation aggregate labels properly * Use auto recreate * Re-apply SpanFilter * Add migration to integration test * Update OpenAPI schema * Update traces router * Update helper test * Cast to floats before doing arithmetic * Add type annotations * Rebuild js client * Use more robust typing * Use a weighted avg for scores - optimize query to not use cartesian product - will scale very poorly as the number of labels increases * Use properly per-span aggregated scores * Cast to float before returning LabelFraction * Add tests * Remove score column from base stmt * Use column indexing * Improve clarity for type checker * Fix unit test type checks
Co-authored-by: Alexander Song <[email protected]>
* feat(annotations): Annotation Config UI * Fix style merging in AnnotationLabel * Handle large values * Rename card * Persist annotation config via gql * Convert annotation config popover to dialog * Implement annotation selection toolbar + deletion * Remove bad lint rule * Replace dialog extra buttons with cancel button * styling changes * clean up annotation label * Remove hover state from annotation label unless clickable
Co-authored-by: Mikyo King <[email protected]>
* temporary * feat(annotations): add a ui to add / remove project annotations
* feat(annotations): addd notes UI to the side-bar * cleanup * add date * add ci * add changes
Additionally: * Add react-aria package and FocusScope * Use dark mode in storybook if OS is set to dark mode
chore: codegen on ts client fix(annotations): fix facilitator chore: fix text chore: openapi and mypy fixes chore: ruff codegen
* feat(annotations): full annotations table * feat(annotations): full annotation table in the feedback tab
* feat(admin): display retention policies * memo
* rudimentary dialogue * create the basic layout * add validation * Add forced refetch * switch to paginated for now * add mode
* feat(admin): project retention policies * WIP * final * final * cleanup * cleanup * cleanup * cleanup
* Create annotation configs feature branch * Add upsert logic to span annotation insertion * Change trace annotation mutation as well * Use SupportedSQLDialect enum * Use default constraint names * Use `create_index` for the partial constraint * Implement backwards-compatible identifier index * Add CODE to allowed annotator kind * Start reorganizing migration to primarily use batch ops * Reorganize downgrade to use batch ops * Fix drop constraint call args * Update constraint name * Improve SpanAnnotation upsert logic * Update trace annotation mutations * Update REST route as well * Fix constraint name in migration * Refactor migrations * Fix rest route * Update test fixtures * Add backwards compatible constraint to document annotations * Add tests * Add backwards compatibility test * Remove needless fixture * Ignore type issues on the return types * Restructure mutation * dedent * decode ids outside transaction * decode trace rowids outside session --------- Co-authored-by: Alexander Song <[email protected]>
* cleanup * add edit * Update app/src/pages/settings/RetentionPolicyActionMenu.tsx Co-authored-by: Anthony Powell <[email protected]> * Update app/src/pages/settings/RetentionPolicyActionMenu.tsx Co-authored-by: Anthony Powell <[email protected]> --------- Co-authored-by: Anthony Powell <[email protected]>
…g annotation configs (#7222)
* Add a per-user identifier to app annotations * Add comment * Satisfy type checker * Add unique identifier to trace annotation mutation * Fix * Update test
…7248) Co-authored-by: Tony Powell <[email protected]> Co-authored-by: Dustin Ngo <[email protected]>
* Create span comment mutation * Use correct id * Comment -> Note * Update gql schema
* Reserve span notes * Update src/phoenix/server/api/routers/v1/spans.py Co-authored-by: Anthony Powell <[email protected]> * Fix line length --------- Co-authored-by: Anthony Powell <[email protected]>
* Add span notes resolver * Update gql schema * Ruff 🐶
dosubot
bot
added
the
size:L
mikeldking
approved these changes
Apr 28, 2025
mikeldking
force-pushed
the
feat/annotations
branch
2 times, most recently
from
88e3b3c to
e9ead03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tables