Skip to content

fix: quick metadata filters for nested fields #7408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

ayush3160
Copy link
Contributor

fixes #7345

This pull request updates the makeMetadataTooltipFilterCondition function in MetadataTooltip.tsx to enhance its handling of nested keys in metadata. The change ensures that keys with dot notation are correctly converted to bracket notation for Python compatibility.

Key Change:

  • Updated the makeMetadataTooltipFilterCondition function to split keys by dots and convert them into bracket notation, enabling support for nested metadata keys. Numeric segments are wrapped in square brackets, while other segments are wrapped in single quotes.

@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix May 3, 2025
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 3, 2025
@mikeldking mikeldking requested a review from cephalization May 4, 2025 04:02
Copy link
Contributor

@cephalization cephalization left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@github-project-automation github-project-automation bot moved this from 📘 Todo to 👍 Approved in phoenix May 5, 2025
@mikeldking mikeldking merged commit b582f95 into Arize-ai:main May 5, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Approved to ✅ Done in phoenix May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[bug][ui] quick metadata filters are incorrect for nested fields
3 participants