Skip to content

feat(annotations): ensure all span annotations are included in dataset examples #7412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025

Conversation

axiomofjoy
Copy link
Contributor

When creating a dataset example from a span, ensures that all span annotations are included in the example.

resolves #6980

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axiomofjoy axiomofjoy force-pushed the xander/dataset-example-annotations branch from 7daa163 to 5393a43 Compare May 3, 2025 22:06
@axiomofjoy axiomofjoy changed the base branch from main to feat/annotations May 3, 2025 22:06
Copy link

pkg-pr-new bot commented May 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/Arize-ai/phoenix/@arizeai/phoenix-client@7412
npm i https://pkg.pr.new/Arize-ai/phoenix/@arizeai/phoenix-mcp@7412

commit: 7daa163

@axiomofjoy axiomofjoy force-pushed the xander/dataset-example-annotations branch from 7b8a72f to 3a7c446 Compare May 4, 2025 01:37
@axiomofjoy axiomofjoy force-pushed the xander/dataset-example-annotations branch from 3a7c446 to e60d5ac Compare May 4, 2025 01:39
@axiomofjoy axiomofjoy marked this pull request as ready for review May 4, 2025 02:28
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 4, 2025
@axiomofjoy
Copy link
Contributor Author

This does not include annotation summaries

@github-project-automation github-project-automation bot moved this from 📘 Todo to 👍 Approved in phoenix May 5, 2025
@axiomofjoy axiomofjoy merged commit e466d2f into feat/annotations May 5, 2025
55 checks passed
@axiomofjoy axiomofjoy deleted the xander/dataset-example-annotations branch May 5, 2025 17:24
@github-project-automation github-project-automation bot moved this from 👍 Approved to ✅ Done in phoenix May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[annotations] propagate "new" annotation info to dataset examples
2 participants