Skip to content

fix(annotations): ensure user identifiers are stable #7414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2025
Merged

fix(annotations): ensure user identifiers are stable #7414

merged 3 commits into from
May 5, 2025
+16 −28

Conversation

axiomofjoy
Copy link
Contributor

resolves #7377

@github-project-automation github-project-automation bot moved this to 📘 Todo in phoenix May 4, 2025
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 4, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/Arize-ai/phoenix/@arizeai/phoenix-client@7414

npm i https://pkg.pr.new/Arize-ai/phoenix/@arizeai/phoenix-mcp@7414

commit: 6b3ab23

@axiomofjoy axiomofjoy changed the base branch from main to feat/annotations May 4, 2025 22:51
@axiomofjoy axiomofjoy requested a review from anticorrelator May 5, 2025 20:45
@axiomofjoy axiomofjoy force-pushed the xander/user-identifier branch from 6b3ab23 to 4948e16 Compare May 5, 2025 20:45
@axiomofjoy axiomofjoy marked this pull request as ready for review May 5, 2025 20:52
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 5, 2025
@github-project-automation github-project-automation bot moved this from 📘 Todo to 👍 Approved in phoenix May 5, 2025
@axiomofjoy axiomofjoy merged commit 1753e74 into feat/annotations May 5, 2025
55 checks passed
@axiomofjoy axiomofjoy deleted the xander/user-identifier branch May 5, 2025 21:44
@github-project-automation github-project-automation bot moved this from 👍 Approved to ✅ Done in phoenix May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeldking mikeldking mikeldking approved these changes

@anticorrelator anticorrelator Awaiting requested review from anticorrelator

Assignees
No one assigned
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[annotations] make user identifiers stable
2 participants
@axiomofjoy @mikeldking