feat: added Odrive S1 BLDC motor control support via can bus#1065
Open
arthurtumanyan wants to merge 1 commit into
Open
feat: added Odrive S1 BLDC motor control support via can bus#1065arthurtumanyan wants to merge 1 commit into
arthurtumanyan wants to merge 1 commit into
Conversation
Owner
|
Thanks. One of the design principles of Moonraker is that direct robot control is strictly in Klipper's domain and Moonraker should not encroach on it. This would apply to steppers, servos, heaters, and various sensors. From Klipper it is possible to register endpoints that are proxied via Moonraker that expose direct control if necessary, although it would likely be more efficient to simply register GCode Commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support to control Odrive S1 motor controller via REST API . Motor controller should be connected to Klipper supported device via CAN bus.
Successfully tested on manta-m8p device.
Example of request:
curl -X POST http://<moonraker_ip>:7125/machine/odrive/command -H "Content-Type: application/json" -d '{"action": "H0", "distance": 0}'
curl -X POST http://moonraker_ip:7125/machine/odrive/command -H "Content-Type: application/json" -d '{"action": "G0", "distance": 100}'
curl -X POST http://moonraker_ip:7125/machine/odrive/command -H "Content-Type: application/json" -d '{"action": "RESET"}'