Fix CreateByRelativePathCoreAsync file-tail detection for StorableType.Folder#106
Open
Arlodotexe wants to merge 1 commit intomainfrom
Open
Fix CreateByRelativePathCoreAsync file-tail detection for StorableType.Folder#106Arlodotexe wants to merge 1 commit intomainfrom
Arlodotexe wants to merge 1 commit intomainfrom
Conversation
…e.Folder Excludes file-like path segments from folder creation loop to prevent treating 'file.txt' as folder name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
CreateByRelativePathCoreAsyncfile-tail detection forStorableType.Folderto prevent treating file paths likepath/to/file.txtas folder paths during folder creation.Root Cause
The folder creation loop in
CreateByRelativePathCoreAsynciterated over ALL path segments without checking if the last segment represented a file (indicated by dots suggesting extensions). This caused paths likeassets/images/hero.pngto create a folder namedhero.png.Fix
Added file-tail detection using existing
LooksLikeFileTailhelper:Validation
hero.pngfolder)/C:\/Users/.../images/hero.pngbefore fix