Skip to content

Stabilize SystemFolder watcher tests #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Arlodotexe merged 1 commit into from
Aug 18, 2025
Merged

Stabilize SystemFolder watcher tests #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions tests/OwlCore.Storage.Tests/SystemIO/SystemFolderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ public class SystemFolderTests : CommonIModifiableFolderTests
{
public override Task<IModifiableFolder> CreateModifiableFolderAsync()
{
var directoryInfo = Directory.CreateDirectory(Path.GetTempPath());
var tempFolder = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
var directoryInfo = Directory.CreateDirectory(tempFolder);

return Task.FromResult<IModifiableFolder>(new SystemFolder(directoryInfo.FullName));
return Task.FromResult<IModifiableFolder>(new SystemFolder(directoryInfo.FullName));
}

public override Task<IModifiableFolder> CreateModifiableFolderWithItems(int fileCount, int folderCount)
Expand Down Expand Up @@ -38,15 +39,17 @@ public override Task<IModifiableFolder> CreateModifiableFolderWithItems(int file
// TODO: Move these to CommonTests.

[TestMethod]
[Timeout(2000)]
public async Task FolderWatcherOnFileCreate()
{
var folder = await CreateModifiableFolderAsync();

await using var watcher = await folder.GetFolderWatcherAsync();
var collectionChangedTaskCompletionSource = new TaskCompletionSource();
watcher.CollectionChanged += (sender, args) => collectionChangedTaskCompletionSource.SetResult();

await folder.CreateFileAsync(GetHashCode().ToString(), overwrite: true);
var collectionChangedTaskCompletionSource = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
watcher.CollectionChanged += (sender, args) => collectionChangedTaskCompletionSource.TrySetResult();

var fileName = $"{Guid.NewGuid():N}.tmp";
await folder.CreateFileAsync(fileName, overwrite: true);

await collectionChangedTaskCompletionSource.Task;
}
Expand All @@ -58,23 +61,25 @@ public async Task FolderWatcherOnFolderCreate()
var folder = await CreateModifiableFolderAsync();

await using var watcher = await folder.GetFolderWatcherAsync();
var collectionChangedTaskCompletionSource = new TaskCompletionSource();
watcher.CollectionChanged += (sender, args) => collectionChangedTaskCompletionSource.SetResult();
var collectionChangedTaskCompletionSource = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
watcher.CollectionChanged += (sender, args) => collectionChangedTaskCompletionSource.TrySetResult();

await folder.CreateFolderAsync(GetHashCode().ToString(), overwrite: true);
var folderName = Guid.NewGuid().ToString("N");
await folder.CreateFolderAsync(folderName, overwrite: true);

await collectionChangedTaskCompletionSource.Task;
}

[TestMethod]
[Timeout(2000)]
public async Task FolderWatcherOnDelete()
{
var folder = await CreateModifiableFolderWithItems(1, 0);
var existingItem = await folder.GetItemsAsync(StorableType.File).FirstAsync();

await using var watcher = await folder.GetFolderWatcherAsync();
var collectionChangedTaskCompletionSource = new TaskCompletionSource();
watcher.CollectionChanged += (sender, args) => collectionChangedTaskCompletionSource.SetResult();
var collectionChangedTaskCompletionSource = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
watcher.CollectionChanged += (sender, args) => collectionChangedTaskCompletionSource.TrySetResult();

await folder.DeleteAsync(existingItem);

Expand Down