Skip to content

feat: add Colombian Peso (COP) currency option#386

Merged
ArnasDon merged 1 commit into
ArnasDon:mainfrom
Andeveling:contrib/feat-colombian-peso-currency
Jul 17, 2026
Merged

feat: add Colombian Peso (COP) currency option#386
ArnasDon merged 1 commit into
ArnasDon:mainfrom
Andeveling:contrib/feat-colombian-peso-currency

Conversation

@Andeveling

Copy link
Copy Markdown
Contributor

Summary

Adds Colombian Peso (COP) to the supported currencies list in src/lib/currency.ts, so accounts targeting Latam markets can configure their default currency without overriding the picker.

What changed

  • src/lib/currency.ts — appends { code: "COP", label: "Colombian Peso", symbol: "$" } to CURRENCIES. No other files touched. formatCurrency already routes through Intl.NumberFormat, so the symbol
    and grouping are picked up automatically from the ISO-4217 code; the explicit symbol field is only used by formatCurrencyShort (donut/legend).

Why this might belong upstream despite CONTRIBUTING.md

CONTRIBUTING.md steers "new features" to forks, and a new currency arguably falls there — happy to move it to my fork if the maintainer prefers. The case for considering it upstream:

  • It's a one-line data addition, not a feature in the UX sense: no new component, no new screen, no new setting. Just a row in an existing picker.
  • CURRENCIES already carries several regional options (INR, JPY, BRL, MXN). COP is the same shape and the same gap to fill.
  • Latam is the obvious primary audience for a WhatsApp-first CRM and the upstream copy leans Spanish-first (messages/es-CO.json is shipped).

If the answer is still "belongs in a fork," that's a clean close and I get it.

Test plan

  • npm run typecheck clean.
  • npm run lint — no new errors.
  • npm run build succeeds.
  • Manual: open an account settings → currency picker → confirm COP appears and renders as $1.234,56 (es-CO locale) or COP 1,234.56 (en locale) for a sample deal.

Related

None — opening as a probe to test alignment before investing more in this direction.

@Andeveling
Andeveling requested a review from ArnasDon as a code owner July 14, 2026 11:59
@ArnasDon
ArnasDon merged commit 8bbda77 into ArnasDon:main Jul 17, 2026
1 check passed
@Andeveling
Andeveling deleted the contrib/feat-colombian-peso-currency branch July 18, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants