feat: add Colombian Peso (COP) currency option#386
Merged
ArnasDon merged 1 commit intoJul 17, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Colombian Peso (COP) to the supported currencies list in
src/lib/currency.ts, so accounts targeting Latam markets can configure their default currency without overriding the picker.What changed
src/lib/currency.ts— appends{ code: "COP", label: "Colombian Peso", symbol: "$" }toCURRENCIES. No other files touched.formatCurrencyalready routes throughIntl.NumberFormat, so the symboland grouping are picked up automatically from the ISO-4217 code; the explicit
symbolfield is only used byformatCurrencyShort(donut/legend).Why this might belong upstream despite CONTRIBUTING.md
CONTRIBUTING.mdsteers "new features" to forks, and a new currency arguably falls there — happy to move it to my fork if the maintainer prefers. The case for considering it upstream:CURRENCIESalready carries several regional options (INR, JPY, BRL, MXN). COP is the same shape and the same gap to fill.messages/es-CO.jsonis shipped).If the answer is still "belongs in a fork," that's a clean close and I get it.
Test plan
npm run typecheckclean.npm run lint— no new errors.npm run buildsucceeds.$1.234,56(es-CO locale) orCOP 1,234.56(en locale) for a sample deal.Related
None — opening as a probe to test alignment before investing more in this direction.