Local json compression + optimization for empty encoders#1021
Open
QnJ1c2kNCg wants to merge 2 commits intoArroyoSystems:masterfrom
Open
Local json compression + optimization for empty encoders#1021QnJ1c2kNCg wants to merge 2 commits intoArroyoSystems:masterfrom
QnJ1c2kNCg wants to merge 2 commits intoArroyoSystems:masterfrom
Conversation
Very similar to ArroyoSystems#1007, but for the Local file backend.
We want to only finish/re-create the Gzip encoder if data was written. The previous behavior was that for every checkpoint we would finish/create the encoder regardless of if any user data was written. This effectively added ~20 bytes of nothing at every checkpoint. This patch tracks if we wrote user data to the underlying buffer, marking the buffer as `dirty`, and only finishing the encoder if this flag is set.
cmackenzie1
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Very similar to #1007, but for the Local file backend.
I noticed that the Gzip encoder would produce bytes (header + footer) on every checkpoint even when no user traffic. This patch tracks if we wrote user data to the underlying buffer, marking the buffer as
dirty, and only finishing the encoder if this flag is set.The
dirtyflag starts asfalseand is set totruewhenwrite_all()is called. The flag resets tofalsewhen a new encoder is created.Tested locally a variety of scenarios: