Export job state metrics for Prometheus - #1114
Merged
QnJ1c2kNCg merged 1 commit intoJul 27, 2026
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
mwylde
approved these changes
Jul 27, 2026
cmackenzie1
reviewed
Jul 27, 2026
| .unwrap(); | ||
| } | ||
|
|
||
| fn metric_job_state( |
Collaborator
There was a problem hiding this comment.
Is there a specific reason we re-map all states instead of exposing the states themselves? There is a lot of chance for drift between here and what states may actually exist.
Collaborator
Author
There was a problem hiding this comment.
No strong reason, I initially thought having larger "buckets" would be nicer. However, I agree about the drift risk and it's easy to create "buckets" in dashboards/alerts.
I'll update the PR.
QnJ1c2kNCg
force-pushed
the
broy/job-status-metrics-oss
branch
from
July 27, 2026 20:16
2ce6239 to
d356852
Compare
cmackenzie1
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit job state Prometheus metrics as part of the controller updater loop.