Release job map lock before queue sends - #1117
Merged
Merged
Conversation
Collaborator
Author
|
Cherry picked from #1115 |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
mwylde
approved these changes
Jul 29, 2026
A full state-machine queue caused controller RPC handlers to wait while holding the global job map mutex. One stalled job could therefore prevent messages from reaching every other job. Clone the selected job's sender under the map lock, then release the lock before waiting for channel capacity. This preserves per-job backpressure without making it controller-wide.
cmackenzie1
force-pushed
the
cole/fix-global-lock
branch
from
July 29, 2026 20:13
04793db to
c67bd91
Compare
cmackenzie1
enabled auto-merge (squash)
July 29, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A full state-machine queue caused controller RPC handlers to wait while holding the global job map mutex. One stalled job could therefore prevent messages from reaching every other job.
Clone the selected job's sender under the map lock, then release the lock before waiting for channel capacity. This preserves per-job backpressure without making it controller-wide.