Add gRPC connect timeout on LeaderManager::connect - #1118
Merged
Conversation
Collaborator
Author
|
Replaces #1115 |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
mwylde
approved these changes
Jul 29, 2026
Refactors the related code to plumb the value through to the grpc builder Config is currently limited to the controller with a default of None. This _should_ only affect the Controller -> Leader connection, which currently does not have any supervisor to detect issues. Most (if not all) other connections have some supervisor that will timeout and handle the error accordingly.
cmackenzie1
force-pushed
the
cole/grpc-connect-leaders
branch
from
July 29, 2026 20:08
220e049 to
a96bb73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the related code to plumb the value through to the grpc builder Config is currently limited to the controller with a default of None.
This should only affect the Controller -> Leader connection, which currently does not have any supervisor to detect issues. Most (if not all) other connections have some supervisor that will timeout and handle the error accordingly.