Repository navigation
fix(security): harden ownership, authentication, and page requests - #1200
Merged
Merged
Conversation
qwqcode
force-pushed
the
security-audit-boundaries
branch
from
October 25, 2026 12:15
cdbb023 to
1be600d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tightens access to pending comments and notifications, bounds page creation and title fetching, and keeps sidebar login credentials out of request URLs while preserving normal anonymous commenting and PV counting.
Changes
page_title_auto_fetch, disabled by default; manual fetching remains available.Upgrade behavior
Deploy the backend, comment frontend, and sidebar assets together. An old frontend still puts its JWT in the initial request URL; accepting that format only preserves compatibility and cannot undo the initial exposure.
Guest access follows possession of the browser credential, not a supplied name or email. Existing comments without a credential hash cannot acquire anonymous ownership merely by matching those fields. Clearing browser storage loses the guest proof; blocked storage supports the current page session only. Public comments and administrator access remain available.
Database migration adds the ownership hash and verification-attempt fields, preserves the earlier security-branch hash column on rename, and stops startup on migration failure. Automatic title fetching now requires explicit opt-in.
Validation
1be600da: PR browser end-to-end CI, Go and database CI, documentation CI, and workflow syntax/security checks and frontend CI all passed.ui/artalkESLint check passes with--max-warnings 0; all 7 guest-identity regression tests passed locally.All applicable PR checks must complete before merging.