Repository navigation
Conversation
qwqcode
force-pushed
the
codex/docs-recommend-ipdb
branch
from
October 28, 2026 14:42
8575f9b to
af9033b
Compare
qwqcode
force-pushed
the
codex/docs-recommend-ipdb
branch
from
October 28, 2026 14:47
af9033b to
62c8df6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling the global cache previously made every IPDB lookup reload the entire database file. Keep the IPDB reader in memory after the first successful load regardless of
cache.enabled, while preserving XDB's existing memory/file behavior. Failed loads can still retry, and reinitializing the service loads a replacement database.Recommend qqwry standard IPDB first in both language guides, update the example path, and explain its reader lifetime. Retain the XDB setup instructions and remove the paragraph about separate IPv4/IPv6 files. No new configuration fields or dependencies are introduced.
Copy rate limiter keys before retaining them: Fiber may reuse the request buffer backing an IP string after a request ends. Retaining that borrowed string could lose an IP's quota after another request, affecting page creation and notification-read limits. A deterministic regression test covers buffer reuse and independent IP quotas.
Validation:
CGO_ENABLED=0 go test -coverprofile=/tmp/artalk-1204-ci-coverage.out ./...,go vet ./...,go test -race ./internal/limiter ./server/handler,go test -race ./internal/ip_region ./internal/core, and Prettier checks for both guides passed. The new limiter regression test failed before the fix and passed 100 consecutive runs after it. IPDB regression coverage includes cache disabled/enabled, uppercase.IPDB, concurrent lookups, failed-load retry, file replacement, service reinitialization, and unchanged XDB behavior.