Reintroducing wake non-suspend-supported devices from pull request #875#887
Closed
zzahkaboom24 wants to merge 1 commit into
Closed
Reintroducing wake non-suspend-supported devices from pull request #875#887zzahkaboom24 wants to merge 1 commit into
zzahkaboom24 wants to merge 1 commit into
Conversation
Author
|
Reopened in #888 due to this pull request failing the branch/check-branches check, since I have not named my branch "development" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reintroduces the pull request #875 the same way.
I did not add anything to it, I just removed less.
It's also in response to #860, but my aim is specifically this comment: #860 (comment).
This has been tested on Windows 11 with my Glorious GMMK 2 96% ISO, running the latest QMK firmware with ColorHoster added inside, allowing to have OpenRGB compatibility, but like the original pull request author mentioned, and I'll do the same; It works as it should, but of course should be tested on a variety of devices.
My scenario is not the same as the comment in #860, but the prerequisites are the same:
I am using a ColorHoster enabled QMK keyboard.
ColorHoster is OpenRGB compatible, and I presume it does not require "rescan devices" whenever there's a change.
I did not test/use Aurora RGB, but I can confirm that in master branch, when restart Windows, the keyboard has all LEDs off, with no way of getting them to work in Artemis unless I reload the OpenRGB plugin.
I "installed" ColorHoster as a service using ColorHoster.exe --brightness --port 6743 --service create -> ColorHoster.exe --service start.
ColorHoster starts as the very first service, followed by OpenRGB, and finally, Artemis for me.
In theory, everything should behave normally and both my keyboard using ColorHoster on port 6743, and the devices on OpenRGB on port 6742 should have their LED effects applied to them, but the former does not.
As a workaround, I could have reloaded the OpenRGB plugin and that would make my keyboard show up, but as the commenter said, that's quite annoying.
Lastly, unplugging/replugging my keyboard also makes the effects not work anymore, but restarting Artemis using this pull request seems to work (did not test this behaviour on master).
Steps to test:
Notice that all lights should now wake, not just the ones that have the
SuspendSupportedflag set toTrue