Skip to content

Optimizing validate_element in datamodel.py for faster loading of large dmx files #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Almie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimizing validate_element in datamodel.py for faster loading of large dmx files #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions io_scene_valvesource/datamodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,8 @@ def __init__(self,format,format_ver):
self.format_ver = format_ver

self.__elements = []
self.__elements_set = set()
self.__elements_placeholders_set = set()
self.__prefix_attributes = Element(self,"")
self.root = None
self.allow_random_ids = True
Expand All @@ -579,6 +581,11 @@ def __repr__(self):
def validate_element(self,elem):
if elem._is_placeholder:
return

if not elem in self.__elements_set:
return
if elem in self.__elements_placeholders_set:
return

try:
collision = self.elements[self.elements.index(elem)]
Expand All @@ -594,6 +601,10 @@ def add_element(self,name,elemtype="DmElement",id=None,_is_placeholder=False):
elem = Element(self,name,elemtype,id,_is_placeholder)
self.validate_element(elem)
self.elements.append(elem)
if _is_placeholder:
self.__elements_placeholders_set.add(elem)
else:
self.__elements_set.add(elem)
elem.datamodel = self
if len(self.elements) == 1: self.root = elem
return elem
Expand Down