Bazel: general improvements. #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the Bazel build. Attempt to fix previous errors recorded while trying to publish ftxui in the Bazel Central Registry: - bazelbuild/bazel-central-registry#4485 - https://buildkite.com/bazel/bcr-presubmit/builds/13601#01968b61-f5b2-4d16-94d0-c87a03a1a23b Test against "recent" platforms ------------------------------- Previously, I got the error: ``` gcc: error: unrecognized command line option '-std-c++20'; did you mean '-std-c++2a'? ``` This was due to using old distribution like ubuntu 2004. Test against newer platforms only to avoid GCC version<-9.x.y Downgrade gtest version. ------------------------ I suspect this caused the Bazel Central Registry error: ``` file:///workdir/modules/googletest/1.15.2/MODULE.bazel:68:20: name 'use_repo_rule' is not defined ``` I hoped using a lower version will fix the issue. Tag gtest as dev_dependency --------------------------- Presumably, this should avoid dependants to fetch it? Enable --features-layering_check -------------------------------- Aka clang `-Wprivate-header`. Fix the encountered errors. Use clang in the CI ------------------- The CI was defining clang/gcc in the matrix, but was not using it. Fix the bug.
|
Hello @kcc and @robinlinden, Would you have any additional comments / suggestion about FTXUI bazel build files? 1 Footnotes
|
robinlinden
reviewed
May 5, 2025
| # Test deps. | ||
| bazel_dep(name = "googletest", version = "1.16.0.bcr.1") | ||
| # Test dependencies. | ||
| bazel_dep(name = "googletest", version = "1.14.0.bcr.1", dev_dependency = True) |
There was a problem hiding this comment.
There was some discussion in bazelbuild/bazel about test-only deps as dev_dependencies: bazelbuild/bazel#22187
iirc there's some ongoing work on optional dependencies, but I don't think that's in a state where it's usable yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel: general improvements.
Improve the Bazel build. Attempt to fix previous errors recorded while
trying to publish ftxui in the Bazel Central Registry:
Test against "recent" platforms
Previously, I got the error:
This was due to using old distribution like ubuntu 2004. Test against
newer platforms only to avoid GCC version<-9.x.y
Downgrade gtest version.
I suspect this caused the Bazel Central Registry error:
I hoped using a lower version will fix the issue.
Tag gtest as dev_dependency
Presumably, this should avoid dependants to fetch it?
Enable --features-layering_check
Aka clang
-Wprivate-header. Fix the encountered errors.Use clang in the CI
The CI was defining clang/gcc in the matrix, but was not using it. Fix
the bug.