Skip to content

feat(component/app): improve and fix terminal state restoration and s…#1277

Merged
ArthurSonzogni merged 1 commit into
mainfrom
fix-signal
May 26, 2026
Merged

feat(component/app): improve and fix terminal state restoration and s…#1277
ArthurSonzogni merged 1 commit into
mainfrom
fix-signal

Conversation

@ArthurSonzogni

Copy link
Copy Markdown
Owner

…ignal handling

  • Replaced std::signal with POSIX sigaction on non-Windows platforms.
  • Avoided double-restoration of the terminal configuration by implementing atomic g_terminal_is_raw state tracking.
  • Added support for additional crash (SIGBUS, SIGSYS) and termination (SIGQUIT, SIGHUP) signals.
  • Fixed async-signal-safety issues in crash handlers by writing directly to STDOUT_FILENO and bypassing stream buffers.
  • Realigned Event::CtrlC to SIGINT for proper graceful uninstallation flow.
  • Added comprehensive unit tests for all registered signals.

…ignal handling

- Replaced std::signal with POSIX sigaction on non-Windows platforms.
- Avoided double-restoration of the terminal configuration by implementing atomic g_terminal_is_raw state tracking.
- Added support for additional crash (SIGBUS, SIGSYS) and termination (SIGQUIT, SIGHUP) signals.
- Fixed async-signal-safety issues in crash handlers by writing directly to STDOUT_FILENO and bypassing stream buffers.
- Realigned Event::CtrlC to SIGINT for proper graceful uninstallation flow.
- Added comprehensive unit tests for all registered signals.
@github-actions

Copy link
Copy Markdown

⚠️ ABI Compatibility Report

Comparing main (base) with HEAD (PR)

ABI fingerprints changed from 82dec8d9df5ac9b07447cb2e3d757a02624a33e8fd1f6cea81898a28ebe56ace to bf3eebaf7987ff009456408689af452c606c89b216d660a90d5474bce7a8d91f.

Detailed ABI Analysis
Checking ABI changes between origin/main and HEAD...
Building origin/main...
Building HEAD...
--------------------------------------------------------------------------------
Comparing libftxui-screen.so...
No ABI changes detected for libftxui-screen.so.
--------------------------------------------------------------------------------
Comparing libftxui-dom.so...
No ABI changes detected for libftxui-dom.so.
--------------------------------------------------------------------------------
Comparing libftxui-component.so...
No ABI changes detected for libftxui-component.so.
--------------------------------------------------------------------------------
No ABI changes detected.

@ArthurSonzogni ArthurSonzogni merged commit 485a175 into main May 26, 2026
20 checks passed
@ArthurSonzogni ArthurSonzogni deleted the fix-signal branch May 26, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant