Export internal symbols for shared library builds (#1283)#1284
Merged
Conversation
|
ceff73a to
8b6c740
Compare
These symbols are internal to FTXUI (located in src/), but they must be exported when building as shared libraries because of internal dependencies between the screen, dom, and component libraries. - SCREEN symbols in string_internal.hpp are used by COMPONENT. - DOM symbols in node_decorator.hpp are used by COMPONENT. Also: - Bump minor version to 6.2.0 due to ABI changes. - Update tools/abi_fingerprint.txt. - Fix Meson build for Windows and shared library mode by setting necessary export definitions.
8b6c740 to
38a56b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These symbols are internal to FTXUI (located in src/), but they must be exported when building as shared libraries because of internal dependencies between the screen, dom, and component libraries. This also allows the test suite to link correctly in shared library mode.