Accessible icon set - #441
Open
jacobrose wants to merge 2 commits into
Open
Conversation
Adds the 'accessible' format, which replaces the "stoplight" colored circles, which may be unclear to colorblind users, with distinct icons, and replaces the up arrow, which uses a different visual language and may be described differently on screen readers, with one that stylistically matches the down arrow.
Contributor
Coverage report
Test suite run success166 tests passing in 55 suites. Report generated by 🧪jest coverage report action from 3ca903e |
jacobrose
commented
Sep 26, 2025
ArtiomTr
approved these changes
Sep 29, 2025
ArtiomTr
left a comment
ArtiomTr
left a comment
Owner
There was a problem hiding this comment.
Thank you for pull request! This is really amazing change that I would love to have. Don't want to push it as default, would love to make it default in next major version
| "small_red_triangle_down": "🔻", | ||
| "green_circle": "✅", | ||
| "yellow_circle": "⚠️", | ||
| "red_circle": "❎", |
Owner
There was a problem hiding this comment.
Don't really like that it is green, maybe ⛔ or 🚫?
Author
There was a problem hiding this comment.
Oh, but there's also "x": "❌"
🤔
Author
There was a problem hiding this comment.
Just looking at how these are read by the screen reader in MacOS:
- "⛔" is read as "no entry"
- "🚫" is read as "restricted symbol"
- "❌" is read as "cross mark"
What do you think?
Some other options:
- "👍" for "green circle" and "👎" for "red circle" (keeping "
⚠️ " for "yellow circle") - "😁" for "green circle," "😬" for "yellow circle," and "😩" for "red circle"
Owner
|
(ignore the CI, needs an update) |
The chick was read as "recently hatched chick still in shell," which is verbose; the replacement is read as 'new sign.'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the 'accessible' format, which replaces the "stoplight" colored circles, which may be unclear to colorblind users, with distinct icons, and replaces the up arrow, which uses a different visual language and may be described differently on screen readers, with one that stylistically matches the down arrow.