feat: add schemas to the release CI#2040
Open
Gara-Dorta wants to merge 5 commits into
Open
Conversation
Contributor
|
The naming convention is respected, |
Contributor
Author
|
Thanks for reviewing. Glad to see that you found time like you said you would in the reproducible PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #1952 . It builds the json schema on the CI and publishes the files as part of the release.
This is useful to so that people can have access to the schemas without the need to compile the code.
I've tested this in my own fork and the final release looks like this https://github.com/Gara-Dorta/signal-cli/releases/tag/untagged-a596e515c3e97c80bb72 and this is the CI job that generated it https://github.com/Gara-Dorta/signal-cli/actions/runs/25370584365
The build/release time is not significantly affected as the schema generation gets done when the code is compiled in the main build step. So it avoids compiling twice just for this.