Repository navigation
[fsdp, rollout, vllm, model, hardware] feat: integrate MXFP QAT with vLLM-Ascend - #2
Merged
Sunwish merged 5 commits intoOct 29, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Integrates MXFP QAT between FSDP training and vLLM-Ascend rollout.
This PR adds a rollout configuration bridge that exports verl MXFP QAT settings to the vLLM-Ascend environment contract. When enabled, vLLM keeps model weights and kernels on the high-precision path while applying MXFP fake quantization according to the actor QAT configuration.
The PR also fixes several FSDP MXFP training issues:
Related work:
The current PR focuses on FSDP MXFP QAT correctness and its vLLM-Ascend rollout integration.
Checklist Before Starting
[fsdp, rollout, vllm, model, hardware] feat: integrate MXFP QAT with vLLM-Ascend.Test
Added or updated the following tests:
tests/utils/test_mxfp_qat_vllm_ascend.pytests/utils/test_mxfp_quant_cpu.pytests/utils/test_mxfp_moe_cpu.pytests/workers/test_fsdp_mxfp_qat_weight_sync.pyValidation performed:
git diff --check 027ccfd9^..9636ae06passed.python -m pytest tests/utils/test_mxfp_quant_cpu.py tests/utils/test_mxfp_moe_cpu.py tests/utils/test_mxfp_qat_vllm_ascend.py tests/workers/test_fsdp_mxfp_qat_weight_sync.py -qAPI and Usage Example
Example FSDP2 plus vLLM-Ascend configuration:
Supported rollout mappings include:
group_size must be 32. Stochastic rounding modes such as random and hash require quant_backend: torch. Enabling rollout.qat_fake_quant requires an Ascend NPU and vLLM-Ascend.
When rollout fake quantization is enabled, the server keeps the high-precision path, ignores rollout.quantization, and passes the MXFP settings through environment variables consumed by vLLM-Ascend.
Design & Code Changes
Compatibility Note
The generated rollout configurations now inherit qat from actor_rollout_ref.actor.fsdp_config.qat only. The previous fallback to actor_rollout_ref.actor.megatron.qat was removed.
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.