fix: Add handling error in python rules#12
Merged
AsfhtgkDavid merged 13 commits intomainfrom Feb 25, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 71.11% 80.57% +9.46%
==========================================
Files 17 17
Lines 1395 1627 +232
==========================================
+ Hits 992 1311 +319
+ Misses 403 316 -87
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR improves error handling in the Python rules processing system by replacing panic-prone ? operators with explicit error handling that logs issues and continues processing remaining rules. This prevents a single failing rule from stopping the entire rule processing pipeline.
Key Changes:
- Replaced
?operator withmatchexpressions for all PyO3 operations (getattr, call1, extract) - Added descriptive error messages for each failure point (getting functions, executing functions)
- Changed behavior from immediate propagation to logging errors and continuing with next rule
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+40
to
+107
| let match_func = match module.getattr("match") { | ||
| Ok(func) => func, | ||
| Err(e) => { | ||
| eprintln!( | ||
| "{}{}{}", | ||
| "Failed to get 'match' function from rule '".yellow(), | ||
| rule_path.display(), | ||
| "': ".yellow(), | ||
| ); | ||
| eprintln!("{e}"); | ||
| continue; | ||
| } | ||
| }; | ||
| let fix_func = match module.getattr("fix") { | ||
| Ok(func) => func, | ||
| Err(e) => { | ||
| eprintln!( | ||
| "{}{}{}", | ||
| "Failed to get 'fix' function from rule '".yellow(), | ||
| rule_path.display(), | ||
| "': ".yellow(), | ||
| ); | ||
| eprintln!("{e}"); | ||
| continue; | ||
| } | ||
| }; | ||
| if match_func.is_callable() && fix_func.is_callable() { | ||
| if match_func | ||
| let is_match = match match_func | ||
| .call1(( | ||
| command.command(), | ||
| command.output().stdout(), | ||
| command.output().stderr(), | ||
| ))? | ||
| .extract::<bool>()? | ||
| )) | ||
| .and_then(|result| result.extract::<bool>()) | ||
| { | ||
| let fixed_command: String = fix_func | ||
| Ok(result) => result, | ||
| Err(e) => { | ||
| eprintln!( | ||
| "{}{}{}", | ||
| "Failed to execute 'match' function in rule '".yellow(), | ||
| rule_path.display(), | ||
| "': ".yellow(), | ||
| ); | ||
| eprintln!("{e}"); | ||
| continue; | ||
| } | ||
| }; | ||
| if is_match { | ||
| let fixed_command: String = match fix_func | ||
| .call1(( | ||
| command.command(), | ||
| command.output().stdout(), | ||
| command.output().stderr(), | ||
| ))? | ||
| .extract()?; | ||
| )) | ||
| .and_then(|result| result.extract()) | ||
| { | ||
| Ok(cmd) => cmd, | ||
| Err(e) => { | ||
| eprintln!( | ||
| "{}{}{}", | ||
| "Failed to execute 'fix' function in rule '".yellow(), | ||
| rule_path.display(), | ||
| "': ".yellow(), | ||
| ); | ||
| eprintln!("{e}"); | ||
| continue; | ||
| } | ||
| }; |
There was a problem hiding this comment.
The new error handling logic for Python rule processing lacks test coverage. Consider adding unit tests that verify:
- Error handling when
getattr("match")fails - Error handling when
getattr("fix")fails - Error handling when
match_func.call1()fails - Error handling when
fix_func.call1()fails - Verification that the loop continues processing other rules after an error
These tests would help ensure the error handling behaves correctly and prevent regressions. Other modules in src/fix/ (like rust.rs and individual rule files) have comprehensive test coverage that could serve as examples.
4 tasks
12 tasks
…l-tests test: add coverage for error handling in python rules (#14)
12 tasks
…l-tests test: add security and error handling tests for python rules
12 tasks
…l-tests test: add security tests for python rules and fix permissions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #9
Type of Change
Testing
Checklist