Skip to content

Conversation

@Orgams
Copy link

@Orgams Orgams commented Jul 3, 2020

config and images generated

Copy link
Owner

@AsherGlick AsherGlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so great that you are submitting this change.

The build script prints out the following warnings:

WARNING: largetplatform has a recipe but no image and will appear purple in the calculator
WARNING: mediumtplatform has a recipe but no image and will appear purple in the calculator
WARNING: solidfueljumpjet has a recipe but no image and will appear purple in the calculator
WARNING: solidfuelthruster has a recipe but no image and will appear purple in the calculator
WARNING: larget-platform has an image but no recipe and will not appear in the calculator
WARNING: mediumt-platform has an image but no recipe and will not appear in the calculator
WARNING: solid-fueljumpjet has an image but no recipe and will not appear in the calculator
WARNING: solid-fuelthruster has an image but no recipe and will not appear in the calculator

It seems that the images in question have a - in them and are not being named correctly.

Some of the items are cut off slightly on the left and the right, would it be better to make the images slightly wider aspect ratio in order to better match what is found on the wiki? Such as in the Nier Automata calculator.

Let me know if any of my comments don't make sense and I will do my best to explain them further.

@@ -0,0 +1,12 @@
#! /bin/bash
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this file is necessary without also including the scraper itself. Feel free to either remove this file or move this file to astroneer/scripts/ along with the scraper. eg: resource_lists/nier automata/scripts. Your decision should also be reflected in the .gitignore file with the resource_lists/astroneer/new_items line


node_modules/

resource_lists/astroneer/new_items
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment on converti_image_item.sh

Printer and Vehicle Bay: "Use a Printer and Vehicle Bay to turn {IN_ITEMS} into {OUT_ITEM}"

Backpack: Use a backpack to turn {IN_ITEMS} into {OUT_ITEM}
Chemistry_Lab: Use a chemistry lab to turn {IN_ITEMS} into {OUT_ITEM}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to swap out spaces for underscores. This should be

Suggested change
Chemistry_Lab: Use a chemistry lab to turn {IN_ITEMS} into {OUT_ITEM}
Chemistry Lab: Use a chemistry lab to turn {IN_ITEMS} into {OUT_ITEM}

This should be changed for all of the recipe types.

Smelting_Furnace: Use a smelting furnace to turn {IN_ITEMS} into {OUT_ITEM}
resources:
Coal:
Alignment_Mod:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to swap out spaces for underscores. This should be

Suggested change
Alignment_Mod:
Alignment Mod:

This should be changed for all of the resources

Medium_Printer: Use a medium printer to turn {IN_ITEMS} into {OUT_ITEM}
Small_Printer: Use a small printer to turn {IN_ITEMS} into {OUT_ITEM}
Smelting_Furnace: Use a smelting furnace to turn {IN_ITEMS} into {OUT_ITEM}
resources:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of the keys in the resource dict is the same as how they are displayed in the calculator. I am not an expert on astroneer but it will probably be better if they are grouped into similar categories, maybe such as keeping base resources near the top, or putting vehicles together, instead of being grouped alphabetically. If there is an in-game ordering to the items that may also be a good choice such as how the minecraft items are ordered based on the in-game creative mode menu ordering.

Comment on lines +14 to +17
- output: 1
recipe_type: Backpack
requirements:
Zinc: -1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment mod needs a "Raw Resource" as well. This is a bit of a technical workaround for default recipes. For example this resource. Which ever recipe is first in this array will be the default resource used on the calculator, but users can switch to other recipes if they want.

This was found via the output of the build script, in addition to the following:

ASTRONEER: Alignment_Mod must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Aluminum must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Aluminum_Alloy must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Atmospheric_Condenser must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Auto_Arm must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Auto_Extractor must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Battery_Sensor must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Beacon must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Boost_Mod must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Buggy must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Button_Repeater must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Carbon must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Ceramic must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Chemistry_Lab must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Copper must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Crane must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Diamond must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Drill_Mod_1 must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Drill_Mod_2 must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Drill_Mod_3 must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Drill_Strength_1 must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Drill_Strength_2 must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Drill_Strength_3 must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Dynamite must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: EXO_Request_Platform must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Explosive_Powder must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Extenders must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Extra_Large_Arch_Platform must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Extra_Large_Curved_Platform must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Extra_Large_Platform_A must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Extra_Large_Platform_B must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Extra_Large_Platform_C must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Extra_Large_Shredder must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Extra_Large_Storage must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Field_Shelter must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Figurine_Platform must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Fireworks must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Floodlight must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Glass must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Glowsticks must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Graphene must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Holographic_Figurine must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Hydrazine must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Hydrazine_Jet_Pack must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Hydrazine_Thruster must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Inhibitor_Mod must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Iron must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Landing_Pad must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Curved_Platform must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Fog_Horn must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Hoop_Platform_A must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Hoop_Platform_B must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Platform_A must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Platform_B must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Platform_C must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Printer must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Resource_Canister must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Rover must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Rover_Seat must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Shredder must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Shuttle must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Storage must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Storage_Ring must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Storage_Silo_A must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_Storage_Silo_B must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Large_T-Platform must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Battery must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Buggy_Horn must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Generator must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Platform_A must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Platform_B must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Platform_C must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Printer must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Resource_Canister must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Rover must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Shredder must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Shuttle must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Soil_Canister must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Solar_Panel must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Storage must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Storage_Silo must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_T-Platform must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Medium_Wind_Turbine must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Nanocarbon_Alloy must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Narrow_Mod must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Oxygen_Filters must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Oxygenator must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Packager must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Paver must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Plastic must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Portable_Oxygenator must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Power_Cells must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Power_Sensor must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Probe_Scanner must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: RTG must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Recreational_Canopy must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Recreational_Sphere must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Research_Chamber must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Rover_Seat must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Rubber must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Shelter must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Silicone must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Small_Battery must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Small_Camera must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Small_Canister must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Small_Generator must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Small_Oxygen_Tank must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Small_Printer must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Small_Shuttle must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Small_Solar_Panel must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Small_Trumpet_Horn must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Small_Wind_Turbine must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Smelting_Furnace must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Soil_Centrifuge must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Solar_Array must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Solid-Fuel_Jump_Jet must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Solid-Fuel_Thruster must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Splitter must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Steel must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Storage_Sensor must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Tall_Platform must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Tall_Storage must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Terrain_Analyzer must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Tether must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Titanium must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Titanium_Alloy must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Tractor must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Trade_Platform must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Trailer must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Tungsten must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Tungsten_Carbide must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Wide_Mod must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Winch must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Worklight must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself
ASTRONEER: Zinc must have a "Raw Resource" which outputs 1 and has a requirement of 0 of itself

Compound: -2
Quartz: -2
Zinc: -1
Large_Storage_Silo_A:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build script has the issue.

WARNING: largestoragesiloa has a recipe but no image and will appear purple in the calculator

The image appears to be missing.

---
authors:
Asher: "https://aglick.com"
Kevin: ""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove the old authors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants