Skip to content

Fix Lovable sync workflows: remove invalid job-level secrets condition#73

Merged
Asper Beauty Shop (asperpharma) merged 3 commits into
mainfrom
copilot/setup-auto-deployment
Mar 5, 2026
Merged

Fix Lovable sync workflows: remove invalid job-level secrets condition#73
Asper Beauty Shop (asperpharma) merged 3 commits into
mainfrom
copilot/setup-auto-deployment

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 4, 2026

Both Lovable sync workflows were failing on every trigger because secrets context is not available in job-level if conditions in GitHub Actions — only in step-level env/run fields.

Changes

  • sync-file-changes-to-lovable.yml / sync-issues-prs-to-lovable.yml: Removed invalid job-level condition:
    # Before (invalid — secrets unavailable at job level, causes workflow validation failure)
    if: secrets.LOVABLE_WEBHOOK_URL != ''
    
    # After — removed; graceful skip already handled inside the run script
  • Fixed misleading header comment in both files: "will FAIL if not configured""skips gracefully if not configured", matching the actual exit 0 behavior already in the shell scripts.

The if [ -z "$LOVABLE_WEBHOOK_URL" ] guard inside each step's run block was already doing the right thing — the job-level condition was redundant and broken.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: asperpharma <252395498+asperpharma@users.noreply.github.com>
Copilot AI changed the title [WIP] Setup auto-deployment to Lovable for edits Fix Lovable sync workflows: remove invalid job-level secrets condition Mar 4, 2026
@asperpharma Asper Beauty Shop (asperpharma) marked this pull request as ready for review March 5, 2026 11:44
Copilot AI review requested due to automatic review settings March 5, 2026 11:44
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 5, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: 1eeac517-1f96-4f21-823f-9bece8f3b6eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

@asperpharma Asper Beauty Shop (asperpharma) merged commit 42c6480 into main Mar 5, 2026
2 checks passed
@asperpharma Asper Beauty Shop (asperpharma) deleted the copilot/setup-auto-deployment branch March 5, 2026 11:45
Copy link
Copy Markdown
Member

@asperpharma asperpharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dssd

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes GitHub Actions workflow validation failures for the optional Lovable sync workflows by removing an invalid job-level if: that referenced the secrets context, and aligns the header documentation with the existing “skip gracefully” behavior.

Changes:

  • Removed the job-level if: secrets.LOVABLE_WEBHOOK_URL != '' condition from both Lovable sync workflows.
  • Updated workflow header comments to state the workflows “skip gracefully” when LOVABLE_WEBHOOK_URL isn’t configured.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/sync-issues-prs-to-lovable.yml Removes invalid job-level secrets-based condition; updates header comment to match step-level graceful skip logic.
.github/workflows/sync-file-changes-to-lovable.yml Removes invalid job-level secrets-based condition; updates header comment to match step-level graceful skip logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants