Fix Lovable sync workflows: remove invalid job-level secrets condition#73
Conversation
Co-authored-by: asperpharma <252395498+asperpharma@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes GitHub Actions workflow validation failures for the optional Lovable sync workflows by removing an invalid job-level if: that referenced the secrets context, and aligns the header documentation with the existing “skip gracefully” behavior.
Changes:
- Removed the job-level
if: secrets.LOVABLE_WEBHOOK_URL != ''condition from both Lovable sync workflows. - Updated workflow header comments to state the workflows “skip gracefully” when
LOVABLE_WEBHOOK_URLisn’t configured.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/sync-issues-prs-to-lovable.yml | Removes invalid job-level secrets-based condition; updates header comment to match step-level graceful skip logic. |
| .github/workflows/sync-file-changes-to-lovable.yml | Removes invalid job-level secrets-based condition; updates header comment to match step-level graceful skip logic. |
Both Lovable sync workflows were failing on every trigger because
secretscontext is not available in job-levelifconditions in GitHub Actions — only in step-levelenv/runfields.Changes
sync-file-changes-to-lovable.yml/sync-issues-prs-to-lovable.yml: Removed invalid job-level condition:"will FAIL if not configured"→"skips gracefully if not configured", matching the actualexit 0behavior already in the shell scripts.The
if [ -z "$LOVABLE_WEBHOOK_URL" ]guard inside each step'srunblock was already doing the right thing — the job-level condition was redundant and broken.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.