-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support 'this' type on methods and properties #2906
base: main
Are you sure you want to change the base?
Conversation
FYI, I considered trying to bind the prototype instance to the derived type, but I couldn't quite get that way to work. So instead, I resolve the current "this" to use as the class instance instead. It works, but let me know if there's a better way to approach this. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we create an override method for inheritance class
e.g.
for class A extends B
, B has method foo
return this
, we resolve it as return B
. A will generate override method foo
return A
.
Then resolve function should resolve to correct function.
I explored this a bit. It would have side effects, even without using the For example, given: class X {
private foo: i32 = 0;
doSomething(): void {
this.foo = 1;
}
}
class Y extends X {
} ... we can't just transform it to this: class X {
private foo: i32 = 0;
doSomething(): void {
this.foo = 1;
}
}
class Y extends X {
doSomething(): void {
this.foo = 1;
}
} ... because field The resolver implementation does effectively create an alias of the member, but in doing so it uses the original prototype, bound to the base instance. It doesn't create an actual override. |
Fixes #2904
Changes proposed in this pull request:
this
type on class methods and propertiesthis
type (would be nice, but is complicated)To clarify, the
this
type was already implemented, but was returning the base type instead of the calling instance type.