Skip to content

Plot system transmission components#894

Merged
oczoske merged 2 commits into
mainfrom
oc/plot_sys_transmission
Apr 1, 2026
Merged

Plot system transmission components#894
oczoske merged 2 commits into
mainfrom
oc/plot_sys_transmission

Conversation

@oczoske
Copy link
Copy Markdown
Collaborator

@oczoske oczoske commented Mar 31, 2026

OpticsManager.system_transmission turned into a method with parameter plot. When plot=True, a plot of the individual transmission components (effects) is created. The automatic wavelength range setting is based on where the total system transmission is larger than one per cent.

This addresses the first point in #893.

cmd = sim.UserCommands(use_instrument="MICADO", set_modes=["SCAO", "IMG_4mas"])
micado = sim.OpticalTrain(cmd)
micado.optics_manager.system_transmission(plot=True)
micado_trans

@oczoske oczoske requested a review from teutoburg March 31, 2026 16:07
@oczoske oczoske self-assigned this Mar 31, 2026
@oczoske oczoske added enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) documentation Improvements or additions to documentation API How users interact with the software optics Related to the optics subpackage (core functionality) labels Mar 31, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 9.52381% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.71%. Comparing base (296a174) to head (34431dd).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
scopesim/optics/optics_manager.py 9.52% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
- Coverage   74.86%   74.71%   -0.16%     
==========================================
  Files          69       69              
  Lines        8903     8921      +18     
==========================================
  Hits         6665     6665              
- Misses       2238     2256      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that would have been useful earlier today 👍

if plot:
# only plot range where sys_trans is larger than zero
wave <<= wave_unit
transval = sys_trans(wave).value
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not transvaal? 😜

@oczoske oczoske merged commit a809e72 into main Apr 1, 2026
45 of 47 checks passed
@oczoske oczoske deleted the oc/plot_sys_transmission branch April 1, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API How users interact with the software documentation Improvements or additions to documentation enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) optics Related to the optics subpackage (core functionality)

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants