Update unsupported CI actions - #231
Merged
Merged
Conversation
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building upon the
modernizebranch (#229), the CI was failing because some of the actions were using unsupported versions, so I went ahead and updated all of them to the latest supported version.I also switched the java distribution from adopt to temurin, see the notes here: https://github.com/actions/setup-java#supported-distributions
Finally, since the
gradle buildstep was failing, I modified it to run theassemblestep first, then upload the APK, and then run the build step and upload any linting reports. That way you can still download the assembled APK even if the checks failed.