Skip to content

DeviceInfoService - #31

Draft
jmlich wants to merge 1 commit into
AsteroidOS:masterfrom
jmlich:deviceinfoservice
Draft

DeviceInfoService#31
jmlich wants to merge 1 commit into
AsteroidOS:masterfrom
jmlich:deviceinfoservice

Conversation

@jmlich

@jmlich jmlich commented Feb 7, 2024

Copy link
Copy Markdown

This is try to implement Device Info Service
https://www.bluetooth.com/specifications/specs/device-information-service-1-1/

  • The minimalistic implementation is part of bluez and it is necessary to turn it off:
echo DeviceID = false >> /etc/bluetooth/main.conf

The AsteroidOS/meta-asteroid#184 should be merged in the same time

screenshot20240207_192023112

@jmlich

jmlich commented Feb 8, 2024

Copy link
Copy Markdown
Author

I am still not sure if it is written correctly. I have seen some situation when the data wasn't refreshed/loaded even if they should.

@jmlich

jmlich commented Feb 8, 2024

Copy link
Copy Markdown
Author

The PnP ID was dropped, as it seems other devices (e.g. PineTime) also doesn't implement that always.

Comment thread src/deviceinfoservice.cpp Outdated
Comment thread src/deviceinfoservice.cpp Outdated
Comment thread src/deviceinfoservice.cpp Outdated
@jmlich

jmlich commented Feb 13, 2024

Copy link
Copy Markdown
Author

I have updated the comments.

@jmlich
jmlich marked this pull request as draft February 17, 2024 14:35
@FlorentRevest

Copy link
Copy Markdown
Member

FWIW (I also had to refresh my mind to remember the state of those PRs :) ) this PR and AsteroidOS/asteroid-settings#97 both looked good to me.

The only reason why these are not merged is because AsteroidOS/meta-asteroid#185 should have been implemented in a different way so it's not Android-specific. With that implemented, I'd gladly merge those PRs.

@jmlich

jmlich commented Apr 17, 2024

Copy link
Copy Markdown
Author

It is still in my backlog. There is just a lot of other things to do (-;

@FlorentRevest

Copy link
Copy Markdown
Member

All good! I just wanted to check I didn't miss anything :) no rush!

@jmlich

jmlich commented Jan 16, 2025

Copy link
Copy Markdown
Author

I was thinking of those changes. It is question if this change should be blocked by AsteroidOS/meta-asteroid#185 The nemo-qml-plugin-systemsettings technically have same interface. It just provides information which can be confusing for end user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants