Remove false dependency on VirtualKeyboard#88
Remove false dependency on VirtualKeyboard#88beroset wants to merge 1 commit intoAsteroidOS:masterfrom
Conversation
This application doesn't need the VirtualKeyboard ECM to compile, so it is removed. Signed-off-by: Ed Beroset <beroset@ieee.org>
|
The goal is also for runtime checking. i.e. to ensure that the QML module to avoid runtime issues (https://api.kde.org/ecm/module/ECMFindQmlModule.html) That's why I think this makes sense to have, but maybe we should keep it as a warning as this check doesn't make much sense when cross compiling. |
|
The RDEPENDS dependency is still here. Does that meet the purpose you have in mind? |
|
Yes, QML modules in general are only needed at runtime and the check is there to make the packager not forget about it. I would very much keep the check. I'm not in favor of removing the check, we should just fix it for Qt5 (or not bother and go Qt6 only). |
|
I just checked, and Qt5VirtualKeyboard does seem to provide the module with the name we're requesting it for. That is the same we're requesting: Then again perhaps 2.1 is not the right version, I'm not sure where the version comes from and how I should know what version to request. |
This application doesn't need the VirtualKeyboard ECM to compile, so it is removed. See also AsteroidOS/meta-asteroid#232 for the corresponding bitbake recipe change.