Skip to content

Remove false dependency on VirtualKeyboard#88

Open
beroset wants to merge 1 commit intoAsteroidOS:masterfrom
beroset:fix-keyboard-dependency
Open

Remove false dependency on VirtualKeyboard#88
beroset wants to merge 1 commit intoAsteroidOS:masterfrom
beroset:fix-keyboard-dependency

Conversation

@beroset
Copy link
Member

@beroset beroset commented Mar 23, 2026

This application doesn't need the VirtualKeyboard ECM to compile, so it is removed. See also AsteroidOS/meta-asteroid#232 for the corresponding bitbake recipe change.

This application doesn't need the VirtualKeyboard ECM to compile, so it
is removed.

Signed-off-by: Ed Beroset <beroset@ieee.org>
@MagneFire
Copy link
Member

The goal is also for runtime checking. i.e. to ensure that the QML module to avoid runtime issues (https://api.kde.org/ecm/module/ECMFindQmlModule.html)

That's why I think this makes sense to have, but maybe we should keep it as a warning as this check doesn't make much sense when cross compiling.

@beroset
Copy link
Member Author

beroset commented Mar 23, 2026

The RDEPENDS dependency is still here. Does that meet the purpose you have in mind?

@PureTryOut
Copy link
Contributor

Yes, QML modules in general are only needed at runtime and the check is there to make the packager not forget about it. I would very much keep the check.
I think the real issue here is that the module is a bit different for Qt5 and the current check can't find it for some reason.

I'm not in favor of removing the check, we should just fix it for Qt5 (or not bother and go Qt6 only).

@PureTryOut
Copy link
Contributor

I just checked, and Qt5VirtualKeyboard does seem to provide the module with the name we're requesting it for.

$ cat /usr/lib/qt5/qml/QtQuick/VirtualKeyboard/qmldir 
module QtQuick.VirtualKeyboard
plugin qtquickvirtualkeyboardplugin
classname QtQuickVirtualKeyboardPlugin
typeinfo plugins.qmltypes
depends QtQuick 2.0
depends QtQuick.Window 2.2
depends QtQuick.Layouts 1.0
depends Qt.labs.folderlistmodel 2.1
depends QtQuick.VirtualKeyboard.Settings 2.2
depends QtQuick.VirtualKeyboard.Styles 2.2

That is the same we're requesting: ecm_find_qmlmodule(QtQuick.VirtualKeyboard 2.1 REQUIRED).

Then again perhaps 2.1 is not the right version, I'm not sure where the version comes from and how I should know what version to request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants