Skip to content

fix: updated reboot logic #9073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zouyonghe merged 2 commits into from
Jul 2, 2026
+61 −0
Merged

fix: updated reboot logic #9073

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26a4a31
Update updator.py
CooperWang0912 Jun 29, 2026
362cf26
test: cover Windows reboot process spawning
zouyonghe Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions astrbot/core/updator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
import subprocess
import sys
import time
import zipfile
Expand Down Expand Up @@ -135,6 +136,11 @@ def _exec_reboot(executable: str, argv: list[str]) -> None:
quoted_args = [f'"{arg}"' if " " in arg else arg for arg in argv[1:]]
os.execl(executable, quoted_executable, *quoted_args)
return
elif os.name == "nt":
subprocess.Popen(
[executable] + argv[1:], creationflags=subprocess.CREATE_NEW_CONSOLE
)
Comment on lines +140 to +142

@gemini-code-assist gemini-code-assist Bot Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The expression [executable] + argv[1:] is redundant because argv is already constructed with executable as its first element (see _build_reboot_argv). You can pass argv directly to subprocess.Popen to simplify the code and avoid unnecessary list slicing and concatenation.

Suggested change
subprocess.Popen(
[executable] + argv[1:], creationflags=subprocess.CREATE_NEW_CONSOLE
)
subprocess.Popen(
argv, creationflags=subprocess.CREATE_NEW_CONSOLE
)

os._exit(0)
os.execv(executable, argv)

def _reboot(self, delay: int = 3) -> None:
Expand Down
Loading