Skip to content

fix(bay): install curl in runtime image for healthcheck#5

Merged
RC-CHN merged 1 commit intoAstrBotDevs:mainfrom
Intro-iu:main
Mar 10, 2026
Merged

fix(bay): install curl in runtime image for healthcheck#5
RC-CHN merged 1 commit intoAstrBotDevs:mainfrom
Intro-iu:main

Conversation

@Intro-iu
Copy link
Contributor

@Intro-iu Intro-iu commented Mar 5, 2026

修复 Bay 镜像健康检查问题(Issue #3

变更

  • pkgs/bay/Dockerfile 的运行时阶段安装 curl,因为基础镜像 python:3.13-slim 默认不包含 curl
  • 这样现有 HEALTHCHECKcurl -f http://localhost:8114/health)可以正常执行。

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求解决了 Bay 服务 Docker 镜像健康检查失败的关键问题。通过在运行时镜像中明确安装 curl,健康检查机制现在可以完全正常工作,确保服务的运行状态能够被可靠地监控。

Highlights

  • 修复 Bay 镜像健康检查: 在 pkgs/bay/Dockerfile 的运行时阶段安装了 curl,以确保 HEALTHCHECK 命令能够正常执行,因为基础镜像 python:3.13-slim 默认不包含 curl
Changelog
  • pkgs/bay/Dockerfile
    • 在运行时阶段添加了 curl 的安装指令,以支持健康检查。
Activity
  • 没有检测到具体的PR活动。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

这个 PR 通过在运行时镜像中安装 curl 来修复健康检查失败的问题,方向是正确的。然而,为了保持 Docker 镜像的最小化和安全性,有一个更好的方法。我建议使用 Python 自带的 urllib 库来执行健康检查,而不是添加一个新的系统依赖。这样可以避免增加镜像的体积和潜在的攻击面。我在 Dockerfile 中留下了具体的修改建议。请注意,如果采纳此建议,deploy/docker/docker-compose.yaml 中的健康检查也需要相应更新。

@RC-CHN RC-CHN merged commit a66cadf into AstrBotDevs:main Mar 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants