Skip to content

fix: possible EXC_GUARD crasher on macOS from close() #10

fix: possible EXC_GUARD crasher on macOS from close()

fix: possible EXC_GUARD crasher on macOS from close() #10

Triggered via pull request June 16, 2025 16:26
Status Failure
Total duration 2m 6s
Artifacts

prs.yml

on: pull_request
Matrix: Build / build
Matrix: Cargo Test / test
Fit to window
Zoom out
Zoom in

Annotations

1 error and 8 warnings
Cargo Test / windows-latest
Process completed with exit code 1.
usage of a legacy numeric method: src/os/apple/txt.rs#L57
warning: usage of a legacy numeric method --> src/os/apple/txt.rs:57:62 | 57 | let value_size = value.map_or(0, |x| x.len().min(u8::max_value() as usize) as u8); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 57 - let value_size = value.map_or(0, |x| x.len().min(u8::max_value() as usize) as u8); 57 + let value_size = value.map_or(0, |x| x.len().min(u8::MAX as usize) as u8); |
creating a `Box` from a void raw pointer: src/os/apple/register.rs#L143
warning: creating a `Box` from a void raw pointer --> src/os/apple/register.rs:143:21 | 143 | _ = Box::from_raw(self.context); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: cast this to a pointer of the appropriate type --> src/os/apple/register.rs:143:35 | 143 | _ = Box::from_raw(self.context); | ^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_raw_with_void_ptr = note: `#[warn(clippy::from_raw_with_void_ptr)]` on by default
casting to the same type is unnecessary (`u32` -> `u32`): src/os/apple/browse.rs#L392
warning: casting to the same type is unnecessary (`u32` -> `u32`) --> src/os/apple/browse.rs:392:35 | 392 | context.more_coming = flags & ffi::kDNSServiceFlagsMoreComing as u32 != 0; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ffi::kDNSServiceFlagsMoreComing` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`u32` -> `u32`): src/os/apple/browse.rs#L18
warning: casting to the same type is unnecessary (`u32` -> `u32`) --> src/os/apple/browse.rs:18:20 | 18 | if flags & ffi::kDNSServiceFlagsAdd as u32 != 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ffi::kDNSServiceFlagsAdd` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default
usage of a legacy numeric method: src/os/apple/txt.rs#L57
warning: usage of a legacy numeric method --> src/os/apple/txt.rs:57:62 | 57 | let value_size = value.map_or(0, |x| x.len().min(u8::max_value() as usize) as u8); | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default help: use the associated constant instead | 57 - let value_size = value.map_or(0, |x| x.len().min(u8::max_value() as usize) as u8); 57 + let value_size = value.map_or(0, |x| x.len().min(u8::MAX as usize) as u8); |
creating a `Box` from a void raw pointer: src/os/apple/register.rs#L143
warning: creating a `Box` from a void raw pointer --> src/os/apple/register.rs:143:21 | 143 | _ = Box::from_raw(self.context); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | help: cast this to a pointer of the appropriate type --> src/os/apple/register.rs:143:35 | 143 | _ = Box::from_raw(self.context); | ^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_raw_with_void_ptr = note: `#[warn(clippy::from_raw_with_void_ptr)]` on by default
casting to the same type is unnecessary (`u32` -> `u32`): src/os/apple/browse.rs#L392
warning: casting to the same type is unnecessary (`u32` -> `u32`) --> src/os/apple/browse.rs:392:35 | 392 | context.more_coming = flags & ffi::kDNSServiceFlagsMoreComing as u32 != 0; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ffi::kDNSServiceFlagsMoreComing` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
casting to the same type is unnecessary (`u32` -> `u32`): src/os/apple/browse.rs#L18
warning: casting to the same type is unnecessary (`u32` -> `u32`) --> src/os/apple/browse.rs:18:20 | 18 | if flags & ffi::kDNSServiceFlagsAdd as u32 != 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ffi::kDNSServiceFlagsAdd` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default