Skip to content

fix(obsidian-nvim): Update plugin spec by removing deprecated options and APIs - #1570

Merged
Uzaaft merged 6 commits into
AstroNvim:mainfrom
wert2all:fix-legacy-commands
Jul 6, 2025
Merged

fix(obsidian-nvim): Update plugin spec by removing deprecated options and APIs#1570
Uzaaft merged 6 commits into
AstroNvim:mainfrom
wert2all:fix-legacy-commands

Conversation

@wert2all

@wert2all wert2all commented Jul 5, 2025

Copy link
Copy Markdown
Contributor

📑 Description

Obsidian commands were updated:

legacy_commands is deprecated, use move from commands likeObsidianBacklinkstoObsidian backlinks``

Commands

@github-actions

github-actions Bot commented Jul 5, 2025

Copy link
Copy Markdown

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft
Uzaaft force-pushed the fix-legacy-commands branch from 9ec03ef to 6d7bbb4 Compare July 6, 2025 12:33
@Uzaaft Uzaaft changed the title fix(obsidian-nvim): replace obsidian legacy command fix(obsidian-nvim): Update plugin spec by removing deprecated options and APIs Jul 6, 2025
@Uzaaft

Uzaaft commented Jul 6, 2025

Copy link
Copy Markdown
Member

@wert2all rebased all the different PRs into a single one.

Could you test this and confirm it still works as intended?

@wert2all

wert2all commented Jul 6, 2025

Copy link
Copy Markdown
Contributor Author

Tested.

@Uzaaft, you removed 'use_advanced_uri` fix, and I fixed it again.

@Uzaaft

Uzaaft commented Jul 6, 2025

Copy link
Copy Markdown
Member

Tested.

@Uzaaft, you removed 'use_advanced_uri` fix, and I fixed it again.

You mean I didnt nest it under that table. Anyways. looks good. :)

@Uzaaft
Uzaaft merged commit 797c37a into AstroNvim:main Jul 6, 2025
16 checks passed
@wert2all
wert2all deleted the fix-legacy-commands branch April 19, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants