fix(trouble-nvim): fix crash when lspkind is unaccessible

[jmxyyy]

📑 Description

Trouble's LSP-related commands crash when lspkind.nvim is unavailable, because kinds is passed a boolean while a table is expected.

📖 Additional Information

[github-actions]

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

• If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

• If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

• Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

• README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

• Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

• Proper usage of opts table rather than setting things up with the config function.

• Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

[Uzaaft]

Wait Im not following whats happening here.
if lspkind_avail is unaccessible and isnt enabled, how are we passing a boolean?

[jmxyyy]

@Uzaaft apologize if my previous description was unclear, as English is not my native language.

:lua local lspkind_avail, lspkind = pcall(require, "lspkind"); local kinds = lspkind_avail and lspkind.symbol_map; vim.print(kinds)

When the lspkind plugin is not installed, the expression kinds = lspkind_avail and lspkind.symbol_map evaluates to the boolean value false. This false value is then passed into trouble/format.lua at line 147:

local icon = ctx.opts.icons.kinds[ctx.item.kind]

Here, a table is expected, so passing a boolean causes a crash.

This issue can be easily reproduced with a minimal configuration:

 { import = "astrocommunity.diagnostics.trouble-nvim" },

Execute the command: :Trouble lsp_document_symbols