Added Dockerfiles #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazzaar
reviewed
Nov 22, 2025
| @@ -0,0 +1,62 @@ | |||
| version: "3.9" | |||
Member
There was a problem hiding this comment.
I think docker-compose now doesn't need this line, but it's ok
gazzaar
reviewed
Nov 22, 2025
|
|
||
| services: | ||
| app: | ||
| image: postgres:13 |
Member
There was a problem hiding this comment.
postgres 13? that's way too old bro, and also we need to use the alpine version for both postgres and redis.
I think we should use postgres17-alpine
gazzaar
reviewed
Nov 22, 2025
| image: postgres:13 | ||
| container_name: multi_tenant_db | ||
| environment: | ||
| POSTGRES_USER: user |
Member
There was a problem hiding this comment.
I think also here we could make use of env variables?
gazzaar
reviewed
Nov 22, 2025
| DATABASE_HOST: app | ||
| DATABASE_PORT: 5432 | ||
| DATABASE_USER: user | ||
| DATABASE_PASSWORD: postgres8090 |
Member
There was a problem hiding this comment.
The same here for env variables
gazzaar
requested changes
Nov 22, 2025
Member
gazzaar
left a comment
gazzaar
left a comment
There was a problem hiding this comment.
Please fix Postgres version and use alpine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hot-reload supported through volume mounting
All services run using
docker compose upcommandAPI is available at