refactor: use VehicleFragment type for all vehicles-v2 data #5608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosvik
changed the title
marius-at-atb
approved these changes
Dec 1, 2025
Collaborator
marius-at-atb
left a comment
marius-at-atb
left a comment
There was a problem hiding this comment.
Lgtm!
Something we may want to address at some point, is that Entur sends us vehicles from both vehicles and mobility. These are named the same, but are different.
After this PR, they will be even less differentiated 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to AtB-AS/atb-bff#420 and AtB-AS/atb-bff#418.
fragments/vehicles.tswas actually mobility types, so I moved them there.VehicleFragmenttype, so I cleand that up and also updated some naming of variables, since it was quite inconsistent.Acceptance criteria