Skip to content

Conversation

@jorunnl
Copy link
Contributor

@jorunnl jorunnl commented Jan 9, 2026

closes https://github.com/AtB-AS/kundevendt/issues/22155

adds check to verify that ticket is sellable in app before building purchaseSelectionBuilder, as it fails otherwise

@jorunnl jorunnl marked this pull request as ready for review January 9, 2026 14:55
@jorunnl jorunnl self-assigned this Jan 9, 2026
import {isValidDateString} from '@atb/utils/date';
import {decodePolylineEncodedGeometry} from '@atb/utils/decode-polyline-geometry';

export const isProductSellableInApp = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have a duplicated isProductSellableInApp in the configuration module. Could you look into having just one?

@jorunnl jorunnl requested a review from reidzeibel as a code owner January 14, 2026 16:01
@jorunnl jorunnl requested a review from marius-at-atb January 14, 2026 16:06
Copy link
Collaborator

@marius-at-atb marius-at-atb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Bonus task: Add a few tests for the isProductSellableInApp util.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants