util: athena-run: use tmp directory, fix filetype#10
Open
MacroLens wants to merge 2 commits intoAthenaFoundation:masterfrom
Open
util: athena-run: use tmp directory, fix filetype#10MacroLens wants to merge 2 commits intoAthenaFoundation:masterfrom
MacroLens wants to merge 2 commits intoAthenaFoundation:masterfrom
Conversation
Change athena-run shell script to use the system's `tmp` directory rather than the ATHENA_HOME directory. Installing athena to ATHENA_HOME that is not writeable to all users, i.e. installing athena as a shared application, makes the athena-run script useless. By using the system's `tmp` directory you are able to write the temporary file needed without having write access to ATHENA_HOME. Fixes a filetype issue when trying to load a .ath file with athena-run. Using athena-run with example.ath results in athena loading example.ath.ath. Which is unintended behavior.
Use a temporary with random string to avoid collisions if multiple users are using athena-run.
Member
|
Thanks for this. The change to using system's I do agree with the update to allow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
athena-runshell script to use the system'stmpdirectory rather than theATHENA_HOMEdirectory.Installing athena to
ATHENA_HOMEthat is not writeable to all users, i.e. installing athena as a shared application, makes theathena-runscript useless.By using the system's
tmpdirectory you are able to write the temporary file needed without having write access toATHENA_HOME.Fixes a filetype issue when trying to load a
.athfile withathena-run. Usingathena-runwithexample.athresults in athena loadingexample.ath.ath. Which is unintended behavior.