address couple of issues with the parsing

[fkr]

addresses #70 - while here also look at Priority being int not string

Description

Attempt at fixing the issue raised in #70

The code tries to parse String to bool, while already a bool is technically present.

Fixes # (issue)

#70

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

[ihatemodels]

This was changed in recent versions of OPNSense, right? Is it backwards compatible?

If not, we will proceed anyways, we should just document this in the Release.

[fkr]

This was changed in recent versions of OPNSense, right? Is it backwards compatible?

If not, we will proceed anyways, we should just document this in the Release.

good point. will check and see to maybe add some case'ing. Will come back with this.

[fkr]

yeah. with older version this breaks.
@ihatemodels since this is a common pattern (API changes to the datatypes and then breakage): would it make sense to add a commandline argument where when starting the exporter a version of API compat could be passed to the exporter? I first thought about getting the info from the firmware endpoint, but in case there is api-compat issue there this would not help.

[ihatemodels]

@fkr Thanks for checking this out! I'm not sure we should introduce such complexity. OPNSense evolves overtime, so our exporter does. I think users using older versions of OPNSense should use older versions of the exporter.

We can just document which version of the exporter is compatible against which version of OPNSense. Also state in the release page that this is breaking change for older versions.

Maybe we can hear other opinions from the community as well?

[fkr]

@ihatemodels indeed - I concur with not making it overly complex. The only reason it came to mind is: the Business Edition of OPNsense is typically one major behind. (25.7.x vs. 25.4.x) .

Are there others here interested in having the current version as well as BE working with the exporter? (eg. same as @ihatemodels mentioned: what does the community say? :)

[Finkregh]

Latest = latest, if you run something older use an older exporter

[stefanDeveloper]

In my opinion, the latest exporter should support the latest opnsense version. So, I totally agree with @Finkregh and @ihatemodels. If you're running the BE version, use an older version that works with it.

[fkr]

Thanks for adding feedback @stefanDeveloper and @Finkregh.

@ihatemodels I will adjust this PR to add something to the docs.