-
-
Notifications
You must be signed in to change notification settings - Fork 708
fix: update broken Visual C++ 2013 redistributable download URLs #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update broken Visual C++ 2013 redistributable download URLs #1552
Conversation
The previous aka.ms URLs for Visual C++ 2013 redistributables (highdpimfc2013x64enu and highdpimfc2013x86enu) were not working and just redirecting to bing.com search site, causing installation failures with 'The file or directory is corrupted and unreadable' errors. Updated to use direct download.visualstudio.microsoft.com URLs: - x64: https://download.visualstudio.microsoft.com/download/pr/10912041/cee5d6bca2ddbcd039da727bf4acb48a/vcredist_x64.exe - x86: https://download.visualstudio.microsoft.com/download/pr/10912113/5da66ddebb0ad32ebd4b922fd82e8e25/vcredist_x86.exe These URLs provide working downloads of Visual C++ 2013 version 12.0.40664.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes broken Visual C++ 2013 redistributable download URLs in the AtlasOS playbook installation script. The previous aka.ms URLs were redirecting to Bing search instead of providing the expected downloads, causing installation failures.
- Replaced non-functional aka.ms shortlinks with direct download.visualstudio.microsoft.com URLs
- Both x64 and x86 URLs updated to provide version 12.0.40664.0 of the Visual C++ 2013 redistributable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
pencilnav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ps.
These links are extracted directly from Microsoft's docs.
They didnt changed any of these invalid short links to a valid one in their docs LOL
TheyCreeper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
thank you! |
Questions
Describe your pull request
Problem
The current aka.ms URLs for Visual C++ 2013 redistributables defined in SOFTWARE.ps1 (https://aka.ms/highdpimfc2013x64enu and https://aka.ms/highdpimfc2013x86enu) are not working and just redirecting to bing.com search site, causing installation failures for Visual C++ Runtime 2013 during the AtlasOS playbook execution.
Error encountered:
Solution
Updated to use direct download.visualstudio.microsoft.com URLs that provide working downloads:
Both URLs provide Visual C++ 2013 version 12.0.40664.0 and have been tested to work correctly.
Changes
src/playbook/Executables/SOFTWARE.ps1with the new download URLs